[Ahmed Abouelnas]

Anyone Could Help Me
I am Trying To Get A Correct Command Or Incorrect Command Script

Code: [Select]

function onPlayerCommand( pPlayer, szCommand, szText )
{
if ( szCommand == "info" || szCommand == "wanted" || szCommand == "setteam1" || szCommand == "setteam2" || szCommand == "team1" || szCommand == "team2" || szCommand == "spawn" || szCommand == "get200" || szCommand == "pr" || szCommand == "freeze" || szCommand == "wantof" || szCommand == "unfreeze" || szCommand == "mute" || szCommand == "unmute" || szCommand == "setwant1" || szCommand == "setwant2" || szCommand == "setwant3" || szCommand == "setwant4" || szCommand == "setwant5" || szCommand == "setwant6" || szCommand == "setwant0" || szCommand == "1" || szCommand == "mos1" || szCommand == "mos2" || szCommand == "amro1" || szCommand == "amro2" || szCommand == "2" || szCommand == "vehlist" || szCommand == "garages" || szCommand == "srl" || szCommand == "srr" || szCommand == "sfl" || szCommand == "sfr" || szCommand == "exp" || szCommand == "taxion" || szCommand == "taxioff" || szCommand == "open" || szCommand == "close" || szCommand == "busy" || szCommand == "online" || szCommand == "vehghoston" || szCommand == "ghoston" || szCommand == "vehghostoff" || szCommand == "ghostoff" || szCommand == "send" || szCommand == "b+" || szCommand == "bank+" || szCommand == "wire" || szCommand == "sp" || szCommand == "st" || szCommand == "spawnscreen" || szCommand == "addon1" || szCommand == "addon2" || szCommand == "addon3" || szCommand == "want1" || szCommand == "want2" || szCommand == "want3" || szCommand == "want4" || szCommand == "want5" || szCommand == "want6" || szCommand == "saveloc" || szCommand == "gotoloc" || szCommand == "out" || szCommand == "cash" || szCommand == "my+" || szCommand == "bank" || szCommand == "login" || szCommand == "register" || szCommand == "autologin" || szCommand == "logout" || szCommand == "skin" || szCommand == "score" || szCommand == "sc1" || szCommand == "cmds" || szCommand == "mycmds" || szCommand == "stop" || szCommand == "start" || szCommand == "/" || szCommand == "aeroport" || szCommand == "airport" || szCommand == "parc" || szCommand == "rep" || szCommand == "admins" || szCommand == "ann" || szCommand == "l1" || szCommand == "l2" || szCommand == "lock" || szCommand == "lock1" || szCommand == "lock2" || szCommand == "wep" || szCommand == "heal" || szCommand == "arm" || szCommand == "msg" || szCommand == "veh" || szCommand == "mypos" || szCommand == "goto" || szCommand == "speedo" || szCommand == "nogoto" || szCommand == "blipon" || szCommand == "blipoff" || szCommand == "col1" || szCommand == "col2" || szCommand == "anim" || szCommand == "msgs" || szCommand == "kick" || szCommand == "ban" || szCommand == "sun" || szCommand == "fog" || szCommand == "cloud" || szCommand == "storm" || szCommand == "rain" || szCommand == "stm" || szCommand == "se" || szCommand == "wea" )
{
MessagePlayer( "Correct Command", pPlayer, Colour( 0, 255, 0 ) )
}
else
{
MessagePlayer( "Invalid Command Type /cmds or ask for help", pPlayer, Colour( 255, 0, 0 ) )
}

return 1;
}I've Made This But It's Too Hard To Write Every Command On My Server
Any Suggestions.................

ThNx In Advance

[Merkel]

Hard? Lol?

Why you use many 'onPlayerCommand' and not in only one?

[Vortrex]

Make a table of all your commands, like this:

Code: [Select]

Commands <- { "command1" , "command2" , "command3" }
Then, see if the command matches one of them, like this:

Code: [Select]

function onPlayerCommand( player , command , params )
{
if( command in Commands )
{
// Correct Command
}
else
{
// Incorrect Command
}

return 1;
}

[Thijn]

Why on earth would you do it like that?

Just use a switch or lot's of if's, and add an default or else.

Code: [Select]

function onPlayerCommand( pPlayer, szCommand, szText )
{
cmd = szCommand.tolower();
if ( cmd == 'info' )
{
//Some code
}
else if ( cmd == 'wanted' )
{
//Some code
}
else
{
MessagePlayer( 'Invalid command', pPlayer );
}


Code: [Select]

function onPlayerCommand( pPlayer, szCommand, szText )
{
cmd = szCommand.tolower();
switch ( cmd ) {
case 'info':
//Some code
break;
case 'wanted':
//Some code
break;
default:
MessagePlayer( 'Invalid command', pPlayer );
break;
}
}