[iulix2012]

Code: [Select]

else if( cmd == "lock"){
  if ( player.Vehicle ){
MessagePlayer( "Your vehicle is locked!", player );
 player.Vehicle.Locked = true;
}else{
MessagePlayer( "You must be in a vehicle to use this command!", player );
}
}
else if( cmd == "unlock"){
  if ( player.Vehicle ){
MessagePlayer( "Your vehicle is unlocked!", player );
 player.Vehicle.Locked = false;
}else{

MessagePlayer( "You must be in a vehicle to use this command!", player );
}
}


[Thijn]

Moved and added code tags.

[NC]

1. Use TABulators.
2. You could add a check for the lock (unlock) command if the vehicle is already closed (opened). Why should someone close a closed car ?

[Yamaza]

I have a more efficient script for this...:

Code: [Select]

function onPlayerCommand( pPlayer, szCommand, szArgs )
{
if ( szCommand == "lock" )
{
if ( !pPlayer.Spawned )
{
MessagePlayer( "You're not spawned.", pPlayer );
return;
}

if ( !pPlayer.Vehicle )
{
MessagePlayer( "You're not in a vehicle.", pPlayer );
return;
}

if ( pPlayer.VehicleSeat > 0 )
{
MessagePlayer( "You're not the driver on this vehicle.", pPlayer );
return;
}

if ( !szArgs )
{
MessagePlayer( "Locks or unlocks the doors of your vehicle. Usage: /" + szCommand + " < ON / OFF >", pPlayer );
return;
}

local veh = pPlayer.Vehicle;

switch ( szArgs )
{
case "on":
if ( veh.Locked )
{
MessagePlayer( "This vehicle is already locked.", pPlayer );
return;
}

veh.Locked = true;
MessagePlayer( "You have locked the doors of the vehicle.", pPlayer );
break;

case "off":
if ( !veh.Locked )
{
MessagePlayer( "This vehicle is already unlocked.", pPlayer );
return;
}

veh.Locked = false;
MessagePlayer( "You have unlock the doors of the vehicle.", pPlayer );
break;

default:
MessagePlayer( "Unknown usage! Usage: /" + szCommand + " < ON / OFF >", pPlayer );
break;
}
}

return 1;
}


Credits: Me

[Thijn]

Why is it more efficient when it has more lines?

[Yamaza]

Because the code runs faster, without else and else if. This more optimized. I checked it with a test of milliseconds.